-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies needed for some ml integration tests #25548
Conversation
Run Python 3.8 PostCommit |
'sqlalchemy>=1.3,<2.0', | ||
'tensorflow>=2.11.0,<3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add these in the test?
Initially, there was a disagreement of adding ML libraries to the apache_beam[test], as it could install lot of unncessary dependencies and also big in size(tensorflow, torch) on to the user machine.
Also, I am removing tensorflow from the python/containers/base_image_requirements_manual.txt since it is blocking the upgrade of protobuf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of adding these dependencies to the respective gradle/tox tasks.
I think they are not getting skipped. They are not visible in Jenkins UI the tests are actually running but not visible in the Jenkins UI. You can look in the console log and search for Line 457 in 977e531
[beam_PostCommit_Python37](https://ci-beam.apache.org/job/beam_PostCommit_Python39/) test suite Line 476 in 977e531
Console log: https://ci-beam.apache.org/job/beam_PostCommit_Python39/1480/consoleFull The tests we see in the Line 470 in 977e531
InferencePostCommitIT
|
Right now, our inference postcommit tests aren't running correctly (context - #25496 (comment)), this gets them running.
Fixes #25547
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.