Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go Code Coverage. #26885

Merged
merged 3 commits into from
May 25, 2023
Merged

Fix Go Code Coverage. #26885

merged 3 commits into from
May 25, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented May 25, 2023

An earlier PR changed the root directory so we could unit test the container dirctories in Go unit test execution, and didn't change the expected file path to upload for coverage. This resolves it.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label May 25, 2023
@lostluck lostluck changed the title Lostluck fix go coverage Fix Go Code Coverage. May 25, 2023
@lostluck lostluck merged commit 43d7ec0 into master May 25, 2023
@lostluck lostluck deleted the lostluck-fix-go-coverage branch May 25, 2023 00:15
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants