-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an annotation to expose transforms to yaml. #28208
Conversation
We should add this to all transforms that are simply parameterized.
R: @Polber |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28208 +/- ##
==========================================
+ Coverage 72.30% 72.36% +0.06%
==========================================
Files 678 679 +1
Lines 99853 100308 +455
==========================================
+ Hits 72197 72591 +394
- Misses 26077 26138 +61
Partials 1579 1579
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this replace the annotation assembly performed in yaml_transform.py
? This would require all transforms used in a YAML pipeline have this annotation, right?
def test_annotations(self): | ||
t = LinearTransform(5, b=100) | ||
annotations = t.annotations() | ||
print(annotations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the print
meant to still be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
This won't replace the assembly performed in `yaml_transform.py, this merely gives indications of how to use other (posibly not-directly-exposed) Beam transforms directly from yaml. |
Any concerns about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concern, just wondering the use-case since the annotations get added in yaml_transform
, but this makes sense for custom transforms/ those not exposed to yaml as you said. LGTM
We should add this to all transforms that are simply parameterized.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.