Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume env vars are set in model handler #29200

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

damccorm
Copy link
Contributor

This broke https://colab.sandbox.google.com/github/apache/beam/blob/master/examples/notebooks/beam-ml/run_custom_inference.ipynb#scrollTo=7f841596-f217-46d2-b64e-1952db4de4e7

since the custom model handler doesn't set _env_vars


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #29200 (171951e) into master (2f8eebb) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #29200   +/-   ##
=======================================
  Coverage   38.36%   38.36%           
=======================================
  Files         687      687           
  Lines      101747   101747           
=======================================
  Hits        39039    39039           
  Misses      61129    61129           
  Partials     1579     1579           
Flag Coverage Δ
python 29.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/ml/inference/base.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor Author

Run Python_Transforms PreCommit

@damccorm damccorm marked this pull request as ready for review October 30, 2023 17:48
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor Author

R: @jrmccluskey since ritesh is out

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit 28f6e33 into master Oct 30, 2023
@damccorm damccorm deleted the users/damccorm/env_vars branch October 30, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants