Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] fix renaming provider caching and YAML schema validation (#29271) #29290

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Nov 3, 2023

Cherry pick #29271 for 2.52.0 release.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #29290 (1833795) into release-2.52.0 (71e9895) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@                Coverage Diff                 @@
##           release-2.52.0   #29290      +/-   ##
==================================================
- Coverage           38.31%   38.28%   -0.04%     
==================================================
  Files                 688      689       +1     
  Lines              101880   101974      +94     
==================================================
+ Hits                39037    39039       +2     
- Misses              61262    61354      +92     
  Partials             1581     1581              
Flag Coverage Δ
python 29.88% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/yaml/yaml_provider.py 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit 058c947 into apache:release-2.52.0 Nov 3, 2023
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants