-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Beam Go to use the new Opaque Protocol Buffers #33434
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The failures are code coverage (Protos everywhere!), and unrelated typescript code. |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
The typescript tests have been failing for 9 months https://github.com/apache/beam/actions/workflows/typescript_tests.yml?query=is%3Asuccess and can be ignored as unrelated. |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @jrmccluskey @robertwb @jrmccluskey @chamikaramj |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly just reviewed the genproto.sh changes and the steps you took, plus did a couple spot checks, but this LGTM once conflicts are resolved
3a8a2b2
to
ea6948f
Compare
Rebase done, and re-ran the updates, which only affected newer/copy pasted code, and some of the prism changes. Merging once the tests all pass. |
Going to revert this, as it's causing unanticipated issues with the import to Google, where it was to have more of a benefit.
Some of the changes can be maintained, but will be re-added separately (such as improvements to the proto generator file, and a more prudent migration to edition=2023). |
See https://go.dev/blog/protobuf-opaque for details on Opaque Protocol Buffers for Go.
This PR has no functional changes, and is almost entirely generated.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.