[#31912] Fix bug in finalization for Prism & fix the Java bundle finalizing tests. #33493
Conversation
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
| @@ -142,10 +142,8 @@ func (ts *testStreamHandler) UpdateHold(em *ElementManager, newHold mtime.Time) | |||
| ts.currentHold = newHold | |||
| ss.watermarkHolds.Add(ts.currentHold, 1) | |||
|
|
|||
| // kick the TestStream and Impulse stages too. | |||
| // kick the TestStream stage to ensure downstream watermark propagation. | |||
There was a problem hiding this comment.
Non-blocking question - What does 'kick' mean in this context?
There was a problem hiding this comment.
Before I answer, what do you think it means?
There was a problem hiding this comment.
'Kick' signals the element manager to integrate the intent of the testStreamHandler's watermark settings under test with related stages' watermark. In other words, if there are remaining elements in test stream, we prevent prematurely setting all the stages' output watermark to infinity. The underlying mechanism by which we signal i.e. 'kick' is to merge the testStreamHandler's ID to the element manager's changedStages property.
There was a problem hiding this comment.
That's right.
Like when you kick a ball, or engage in percussive maintenance on any mechanical device, this "kick" gets the Element Manager moving again, by saying a stage needs to be evaluated, and as it says, to ensure downstream watermark propagation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33493 +/- ##
============================================
- Coverage 59.02% 59.01% -0.01%
Complexity 3185 3185
============================================
Files 1146 1146
Lines 176065 176046 -19
Branches 3368 3368
============================================
- Hits 103917 103898 -19
Misses 68791 68791
Partials 3357 3357 ☔ View full report in Codecov by Sentry. |
…e finalizing tests. (apache#33493)
Unblock two Java Bundle Finalization tests.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.