Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#33513][prism]Handle Time sorted requirement and drop late data. #33515

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Jan 7, 2025

  • Adds Support for @RequireTimeStortedInput
  • Largely forced a fusion break, and then prism automatically sorts data by event time.
  • Adds precise late data handling, dropping received data if the watermark is already past the window.
  • Fixes two of three tests relying on data being "late" without correctly making the data be late, by moving the data past the end of the global window. The test using allowedlateness was skipped for later, when prism starts to support it.

Unblocks 5 tests, but breaks a Reshuffle/Redistribute test, which adds late data. They're disabled for now until we confirm if the tests are valid or not.

Fixes #33513


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@lostluck
Copy link
Contributor Author

lostluck commented Jan 7, 2025

assign set of reviewers

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck
Copy link
Contributor Author

lostluck commented Jan 7, 2025

The Pre-commit Java failures are unrelated (they aren't failing on the changed tests), and appear to be separately flaky (the failed tests change from run to run).

@lostluck lostluck requested a review from damondouglas January 7, 2025 20:03
@lostluck
Copy link
Contributor Author

lostluck commented Jan 7, 2025

R: @damondouglas

A small review. Should be straight forward. Next up... WindowingStrategies!

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@lostluck lostluck merged commit 6509e51 into apache:master Jan 7, 2025
27 of 29 checks passed
@lostluck lostluck deleted the timeSortedAndLate branch January 7, 2025 21:02
jrmccluskey pushed a commit to jrmccluskey/beam that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prism] Support SortedTime input (java annotation & requirement)
2 participants