-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#33513][prism]Handle Time sorted requirement and drop late data. #33515
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
…direct runner. Prism can't run it yet anyway.
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
The Pre-commit Java failures are unrelated (they aren't failing on the changed tests), and appear to be separately flaky (the failed tests change from run to run). |
A small review. Should be straight forward. Next up... WindowingStrategies! |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Unblocks 5 tests, but breaks a Reshuffle/Redistribute test, which adds late data. They're disabled for now until we confirm if the tests are valid or not.
Fixes #33513
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.