Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin protobuf 3 for debezium #33541

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Pin protobuf 3 for debezium #33541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1f90ea
Pin protobuf 3 for debezium
damccorm Jan 8, 2025
ff049aa
CHANGES
damccorm Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,12 @@
## New Features / Improvements

* X feature added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)).
* Upgraded to protobuf 4 (Java) ([#33192](https://github.com/apache/beam/issues/33192)).

## Breaking Changes

* AWS V1 I/Os have been removed (Java). As part of this, x-lang Python Kinesis I/O has been updated to consume the V2 IO and it also no longer supports setting producer_properties ([#33430](https://github.com/apache/beam/issues/33430)).
* Upgraded to protobuf 4 (Java) ([#33192](https://github.com/apache/beam/issues/33192)), but forced Debezium IO to use protobuf 3 ([#33541](https://github.com/apache/beam/issues/33541) because Debezium clients are not protobuf 4 compatible. This may cause conflicts when using clients which are only compatible with protobuf 4.

## Deprecations

Expand Down
11 changes: 11 additions & 0 deletions sdks/java/io/debezium/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,14 @@ task integrationTest(type: Test, dependsOn: processTestResources) {
useJUnit {
}
}

configurations.all (Configuration it) -> {
resolutionStrategy {
// Force protobuf 3 because debezium is currently incompatible with protobuf 4.
// TODO - remove this and upgrade the version of debezium once a proto-4 compatible version is available
// https://github.com/apache/beam/pull/33526 does some of this, but was abandoned because it still doesn't
// work with protobuf 4.
force "com.google.protobuf:protobuf-java:3.25.5"
force "com.google.protobuf:protobuf-java-util:3.25.5"
}
}
1 change: 0 additions & 1 deletion ...ogle-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubGrpcClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
*/
package org.apache.beam.sdk.io.gcp.pubsub;

import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument;
import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkState;

import com.google.auth.Credentials;
Expand Down
Loading