Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define fallback GFLAGS_NS=google in config headers and remove the need of passing the -DGFLAGS_NS=google flags #2878

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chenrui333
Copy link

What problem does this PR solve?

seeing some regression build failure in Homebrew/homebrew-core#204308

/opt/homebrew/Cellar/brpc/1.12.0/include/butil/reloadable_flags.h:63:9: error: use of undeclared identifier 'GFLAGS_NS'
   63 |     if (GFLAGS_NS::RegisterFlagValidator(flag, validate_fn)) {
      |         ^

It would be just better to define GFLAGS_NS=google in config headers

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenrui333
Copy link
Author

relates to #2877

@chenBright
Copy link
Contributor

In my opinion, it is better to use GFLAGS_NAMESPACE instead of GFLAGS_NS.

@chenBright
Copy link
Contributor

The issue has been fixed in in #2877 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants