Merge pull request #1247 from nicolaferraro/e2e-docker-github

chore(test): enable e2e tests with Docker Hub and Github packages
apache · Feb 5, 2020 · 3139eff · 3139eff
2 parents c7bcde6 + d782fe2
commit 3139eff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.github/workflows/pr-kind.yml b/.github/workflows/pr-kind.yml
@@ -69,11 +69,16 @@ jobs:
         kubectl cluster-info
         kubectl describe nodes
     - name: Run IT
+      env:
+        TEST_DOCKER_HUB_USERNAME: ${{ secrets.TEST_DOCKER_HUB_USERNAME }}
+        TEST_DOCKER_HUB_PASSWORD: ${{ secrets.TEST_DOCKER_HUB_PASSWORD }}
+        TEST_GITHUB_PACKAGES_REPO: ${{ secrets.TEST_GITHUB_PACKAGES_REPO }}
+        TEST_GITHUB_PACKAGES_USERNAME: ${{ secrets.TEST_GITHUB_PACKAGES_USERNAME }}
+        TEST_GITHUB_PACKAGES_PASSWORD: ${{ secrets.TEST_GITHUB_PACKAGES_PASSWORD }}
       run: |
         # Compute registry parameters
         CAMEL_K_REGISTRY=$(docker inspect --format '{{.NetworkSettings.IPAddress }}' "kind-registry")
         echo "Using registry ${CAMEL_K_REGISTRY}:5000"
-
         echo "Build project"
         make build-kamel
         echo "Adding maven artifacts to the image context"

diff --git a/e2e/dev_mode_test.go b/e2e/dev_mode_test.go
@@ -36,6 +36,7 @@ func TestRunDevMode(t *testing.T) {
 		Expect(kamel("install", "-n", ns).Execute()).Should(BeNil())
 
 		t.Run("run yaml dev mode", func(t *testing.T) {
+			RegisterTestingT(t)
 			ctx, cancel := context.WithCancel(testContext)
 			defer cancel()
 			piper, pipew := io.Pipe()
@@ -59,6 +60,7 @@ func TestRunDevMode(t *testing.T) {
 		})
 
 		t.Run("run yaml remote dev mode", func(t *testing.T) {
+			RegisterTestingT(t)
 			ctx, cancel := context.WithCancel(testContext)
 			defer cancel()
 			piper, pipew := io.Pipe()