-
Notifications
You must be signed in to change notification settings - Fork 352
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
node_modules/* | ||
public/* | ||
build |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
7 comments
on commit c4593a6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to revert to avoid losing the original documentation and maybe rework with a new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. The "lost" documentation is (theoretically) completely generated, and something changed so it is not generated any more. This change occurred before my PR, I just discovered the problem. Reverting my PR will mean bringing back incorrect, non-generated documentation, that claims to be generated. The solution is to figure out why the 3 pages weren't being generated and fix that so they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need @nicolaferraro to understand a bit better the camel-k documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It's also possible that for some reason the 3 pages are not supposed to be generated any more, in which case a solution would be to bring static copies back, into the new location, removing the claims that they are generated and adding a comment to the effect that they are not supposed to be generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It's also possible that for some reason the 3 pages are not supposed to be generated any more, in which case a solution would be to bring static copies back, into the new location, removing the claims that they are generated and adding a comment to the effect that they are not supposed to be generated.
I think the debug
trait has been removed in the past but we forgot to remove the doc page.
For the other traits, they should be generated, their code is only present in another "addon" package. The command to generate the doc take into account the addons package:
Line 24 in efc8846
go run ./cmd/util/doc-gen --input-dirs ./pkg/trait --input-dirs ./addons/... |
Doc pages are not supposed to be completely auto-generated, in fact there are boundaries in the page to signal where an auto-generated part begins and where it ends. Some traits (e.g. affinity) contained examples that are not auto-generated (they were outside the auto-generated parts).
Those should not be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there's even less connection between jira and GitHub than I thought. Before merging this commit I opened https://github.com/djencks/camel-k/pull/new/CAMEL-14995 about these disappearing doc files but somehow missed that these comments probably indicated that no one had seen that issue.
After several hours of investigation and experimentation I found a way to generate the 2 actually missing files, see #1441. Note that this is not really satisfactory for the reasons listed there, but brings us to a better state than before these changes, as all the allegedly generated files will now be generated, at least until another undetected change leaving historical versions around.
This must stay