Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trait] Extend affinity trait to CronJobs and KnativeServices #2047

Closed
squakez opened this issue Feb 17, 2021 · 1 comment · Fixed by #2078
Closed

[Trait] Extend affinity trait to CronJobs and KnativeServices #2047

squakez opened this issue Feb 17, 2021 · 1 comment · Fixed by #2078
Assignees
@squakez

Comments

@squakez
Copy link
Contributor

squakez commented Feb 17, 2021

Follow up of #2040 (comment)

  • Extend the affinity trait to all deployments supported
  • Refactor the deployment visit strategy if possible
@squakez
Copy link
Contributor Author

squakez commented Feb 18, 2021

I am going to work on this. I already made some similar work in 5dac0b8. I think we can refactor to have a unique place for all traits.

squakez added a commit to squakez/camel-k that referenced this issue Mar 1, 2021
@squakez
refactor(trait): deployment strategy
640ae45 
* Moved the logic of retrieving the deployment strategy outside toleration trait

Ref apache#2047
squakez added a commit to squakez/camel-k that referenced this issue Mar 1, 2021
@squakez
Refactor(trait): affinity
6740f60 
* Introduced the trait for Knative and CronJob

Closes apache#2047
@squakez squakez mentioned this issue Mar 1, 2021
Merged
squakez added a commit to squakez/camel-k that referenced this issue Mar 2, 2021
@squakez
refactor(trait): nil PodSpec check
1372d02 
* Added a check to raise an error on nil PodSpec for affinity and toleration traits
* Related unit test

Ref apache#2047
astefanutti pushed a commit that referenced this issue Mar 2, 2021
@squakez @astefanutti
refactor(trait): deployment strategy
5aa0b5b 
* Moved the logic of retrieving the deployment strategy outside toleration trait

Ref #2047
astefanutti pushed a commit that referenced this issue Mar 2, 2021
@squakez @astefanutti
Refactor(trait): affinity
4898371 
* Introduced the trait for Knative and CronJob

Closes #2047
astefanutti pushed a commit that referenced this issue Mar 2, 2021
@squakez @astefanutti
refactor(trait): nil PodSpec check
cc0daf4 
* Added a check to raise an error on nil PodSpec for affinity and toleration traits
* Related unit test

Ref #2047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squakez squakez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(trait): affinity squakez/camel-k
1 participant
@squakez