Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use container name for "kamel log", too #347

Closed
rhuss opened this issue Jan 21, 2019 · 0 comments
Closed

Use container name for "kamel log", too #347

rhuss opened this issue Jan 21, 2019 · 0 comments

Comments

@rhuss
Copy link
Contributor

rhuss commented Jan 21, 2019

When running "kamel log" on an istio enabled cluster the following output is generated:

./kamel log sample
WARN[0000] error caught during log scraping for pod sample-c5f9598b5-7fh6m: a container name must be specified for pod sample-c5f9598b5-7fh6m, choose one of: [sample istio-proxy] or one of the init containers: [istio-init]
WARN[0005] error caught during log scraping for pod sample-c5f9598b5-7fh6m: a container name must be specified for pod sample-c5f9598b5-7fh6m, choose one of: [sample istio-proxy] or one of the init containers: [istio-init]

As kamel log also knows the name of the container (i.e. its the same as the integration), it could specify that implicitly when calling out to the logging API.
rhuss added a commit to rhuss/camel-k that referenced this issue Jan 21, 2019
@rhuss
fix(kamel log): Use integration name for looking up containers
f366a15 
Use integration name for looking up containers as a fallback if no
container could be found.

If no container could be identified even with the integration name,
use the first container for the log, assuming its the "main" container.

Fixes apache#347
@rhuss rhuss mentioned this issue Jan 21, 2019
Merged
rhuss added a commit to rhuss/camel-k that referenced this issue Jan 21, 2019
@rhuss
fix(kamel log): Use integration name for looking up containers
d6447fa 
Use integration name for looking up containers as a fallback if no
container could be found.

If no container could be identified even with the integration name,
use the first container for the log, assuming its the "main" container.

Fixes apache#347
rhuss added a commit to rhuss/camel-k that referenced this issue Jan 21, 2019
@rhuss
fix(kamel log): Use integration name for looking up containers
52fbe11 
Use integration name for looking up containers as a fallback if no
container could be found.

If no container could be identified even with the integration name,
use the first container for the log, assuming its the "main" container.

Fixes apache#347
lburgazzoli pushed a commit that referenced this issue Jan 21, 2019
@rhuss @lburgazzoli
fix(kamel log): Use integration name for looking up containers
d3e646c 
Use integration name for looking up containers as a fallback if no
container could be found.

If no container could be identified even with the integration name,
use the first container for the log, assuming its the "main" container.

Fixes #347
ipolyzos pushed a commit to ipolyzos/camel-k that referenced this issue Jul 31, 2019
@rhuss @ipolyzos
fix(kamel log): Use integration name for looking up containers
8e1b608 
Use integration name for looking up containers as a fallback if no
container could be found.

If no container could be identified even with the integration name,
use the first container for the log, assuming its the "main" container.

Fixes apache#347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhuss