Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add finalizer to ensure integration children are cleaned up #477

Closed
lburgazzoli opened this issue Feb 21, 2019 · 3 comments
Closed

add finalizer to ensure integration children are cleaned up #477

lburgazzoli opened this issue Feb 21, 2019 · 3 comments
Assignees
@lburgazzoli

Comments

@lburgazzoli
Copy link
Contributor

No description provided.

@astefanutti
Copy link
Member

Note that by default, owned resources are deleted prior to the owner and block its deletion base on the ownerReference.blockOwnerDeletion field, see:

https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#foreground-cascading-deletion

@lburgazzoli
Copy link
Contributor Author

yes I think we need an option that set the cleanup policy:

  • owned
  • finalizer

@astefanutti
Copy link
Member

astefanutti commented Feb 21, 2019 •
edited
Loading

There is a delete option (endpoint and kubectl) that changes the owner deletion behaviour:

https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#setting-the-cascading-deletion-policy

@lburgazzoli lburgazzoli self-assigned this Feb 21, 2019
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Feb 21, 2019
@lburgazzoli
add finalizer to ensure integration children are cleaned up apache#477
f138052
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Feb 21, 2019
@lburgazzoli
add finalizer to ensure integration children are cleaned up apache#477
224c213
@lburgazzoli lburgazzoli mentioned this issue Feb 21, 2019
Merged
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Feb 21, 2019
@lburgazzoli
add finalizer to ensure integration children are cleaned up apache#477
984485e
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Feb 21, 2019
@lburgazzoli
add finalizer to ensure integration children are cleaned up apache#477
09ad170
lburgazzoli added a commit to lburgazzoli/apache-camel-k that referenced this issue Feb 22, 2019
@lburgazzoli
fix review findings apache#477
569c07b
lburgazzoli added a commit that referenced this issue Feb 22, 2019
@lburgazzoli
add finalizer to ensure integration children are cleaned up #477
de0a85b
lburgazzoli added a commit that referenced this issue Feb 22, 2019
@lburgazzoli
fix review findings #477
9e8ee20
valdar pushed a commit to jboss-fuse/camel-k that referenced this issue May 21, 2019
@lburgazzoli @valdar
add finalizer to ensure integration children are cleaned up apache#477
739b9aa
valdar pushed a commit to jboss-fuse/camel-k that referenced this issue May 21, 2019
@lburgazzoli @valdar
fix review findings apache#477
d52f713
ipolyzos pushed a commit to ipolyzos/camel-k that referenced this issue Jul 31, 2019
@lburgazzoli @ipolyzos
add finalizer to ensure integration children are cleaned up apache#477
7f3f079
ipolyzos pushed a commit to ipolyzos/camel-k that referenced this issue Jul 31, 2019
@lburgazzoli @ipolyzos
fix review findings apache#477
63ac635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lburgazzoli lburgazzoli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astefanutti @lburgazzoli