Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rebuild knative integrations when changing sink #662

Closed
nicolaferraro opened this issue May 15, 2019 · 4 comments
Closed

Do not rebuild knative integrations when changing sink #662

nicolaferraro opened this issue May 15, 2019 · 4 comments
Assignees
Labels
area/knative Related to Knative kind/bug Something isn't working
Milestone

Comments

@nicolaferraro
Copy link
Member

nicolaferraro commented May 15, 2019

We should optimize trait management: distinguish build time traits from deployment time.

I've 2 integrations, setting differently some Knative options.

Case 1:

    Knative:
      Configuration:
        Channel - Sinks:     
        Channel - Sources:   
        Enabled:             true
        Endpoint - Sinks:    
        Endpoint - Sources:  default

Case 2:

    Knative:
      Configuration:
        Channel - Sinks:     
        Channel - Sources:   camel
        Enabled:             true
        Endpoint - Sinks:    
        Endpoint - Sources:  default

That's the only difference, they use the same libs.
I run integration 1 and a context is built for it.

I run integration 2 and a new context is built again.

That's because traits explicitly set in the integration are reported into the context.
But it does not make sense to create a new image, because the knative trait does not influence build time properties of the image.

@nicolaferraro nicolaferraro added this to the 1.0.0-M3 milestone Oct 9, 2019
@nicolaferraro nicolaferraro changed the title Optimize trait management: distinguish build time traits from deployment time Do not rebuild knative integrations when changing sink Oct 9, 2019
@nicolaferraro nicolaferraro added kind/bug Something isn't working area/knative Related to Knative labels Oct 9, 2019
@nicolaferraro
Copy link
Member Author

It happens that when I change sink of a knative integration, the kit is rebuilt because the Knative trait configuration is contained in the kit. But it should not..

@lburgazzoli
Copy link
Contributor

I think we had an issue related to this in the past but I'm unable to find it any more

@nicolaferraro nicolaferraro self-assigned this Oct 18, 2019
@nicolaferraro
Copy link
Member Author

Verified it's no more present

@nicolaferraro
Copy link
Member Author

Still present, but not on pure camel k but in knative sources. I.e. when tre knative trait config is filled-in and not computed automatically by the camel k operator.

Any source is rebuilt when changing the sink.

@nicolaferraro nicolaferraro reopened this Oct 24, 2019
@nicolaferraro nicolaferraro modified the milestones: 1.0.0-M3, 1.0.0-M4 Oct 24, 2019
nicolaferraro added a commit to nicolaferraro/camel-k that referenced this issue Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/knative Related to Knative kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants