Fix knative sources #1421
Merged
Fix knative sources #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Apr 22, 2020
At the moment it is fine to have "hardcoded" dependencies but as long term it would be better to switch to capabilities as it it make it easier to support a range of runtime versions |
lburgazzoli
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1419
@lburgazzoli this adds the required libs and capabilities whenever the
knative-sourceinterceptor is used. I don't think we should add a capability to avoid naming the libs directly, or do we?It also add a compatibiity hack to transform the old loader to an interceptor in order for next release to work with all currently released versions of Knative (I'll fix it in Knative 0.15).
Release Note