Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1283: Enhance the kamel log command to show more detail prior to i… #1793

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

phantomjinx
Copy link
Contributor

…nstall

  • Sets up a polling prior to the complete install of an integration
  • First report whether it finds the integration
  • Assume it finds an integration then determine its status
  • If it gets to Building Kit (which can take a while) then find the
    associated IntegrationKit and report its status
  • Finally return to the scraping of the log once the integration is up
    and running

Release Note

NONE

…r to install

* Sets up a polling prior to the complete install of an integration
 * First report whether it finds the integration
 * Assume it finds an integration then determine its status
 * If it gets to Building Kit (which can take a while) then find the
   associated IntegrationKit and report its status
 * Finally return to the scraping of the log once the integration is up
   and running
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phantomjinx, having more info really helps.

I've not tested it, but I see there's some code reporting the state of the integration kit. There is already some info about that, because Kubernetes events are also printed.

Have you checked this when installing the operator + running kamel with a admin user (an user that can manage Kubernetes events), to see if there's some duplication.

This of course should work with any kind of users.

@phantomjinx
Copy link
Contributor Author

Thanks @phantomjinx, having more info really helps.

I've not tested it, but I see there's some code reporting the state of the integration kit. There is already some info about that, because Kubernetes events are also printed.

Have you checked this when installing the operator + running kamel with a admin user (an user that can manage Kubernetes events), to see if there's some duplication.

Hey @nicolaferraro

Been developering & running this through as cluster-admin. The events for the integration-kit are more detailed in that they include information of conditions and scaling up. The reason I include mention of the integration-kit in the kamel log is due to the Build Running phase of the integration taking the bulk of the time. Without mention of the integration-kit, the integration log just sits there for 2-3 minutes. Anyway, this is an example of kamel log sample:

⌁66% [: … camel-k] master(1) 130 ± kamel log sample
Integration 'sample' not yet available. Will keep checking ...
The building kit for integration 'sample' is at: Build Submitted
The building kit for integration 'sample' is at: Build Running
Integration 'sample' is at: Deploying ...
Integration 'sample' is now running. Showing log ...
[1] Monitoring pod sample-746854ccb4-5zgct
[1] exec java -cp ./resources:/etc/camel/conf:/etc/camel/resources:/etc/camel/sources/i-source-000:dependencies/camel-k-integration-1.3.0-SNAPSHOT-runner.jar:dependencies/io.quarkus.arc.arc-1.8.0.Final.jar:dependencies/io.quarkus.quarkus-arc-1.8.0.Final.jar:dependencies/io.quarkus.quarkus-bootstrap-runner-1.8.0.Final.jar:dependencies/io.quarkus.quarkus-core-1.8.0.Final.jar:dependencies/io.quarkus.quarkus-development-mode-spi-1.8.0.Final.jar:dependencies/io.quarkus.quarkus-ide-l
....

Let me know if you think it needs tuning further.

Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@nicolaferraro nicolaferraro merged commit b2562d3 into apache:master Nov 2, 2020
@nicolaferraro nicolaferraro mentioned this pull request Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants