-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command line support for creating, building and running containerized integrations locally #1827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @doru1004 , it looks really promising. Just some comments to improve it.
Another issue is that |
I fixed this. There were several other files and folders emitted and now no intermediate files/folders are emitted in the current directory. |
Seems there is some other issue, I can't get |
It looks like this has nothing to do with the latest changes, it probably has to do with redirecting the output of the command. |
The |
I have updated the patch to fix the reported problems. I have also changed the directories used inside the image to be the same ones used in the Kubernetes case! :) |
@nicolaferraro not sure why the knative test failed, it looks like there is a similar failure in master. |
39d95b3
to
43f8d6c
Compare
Rebased on latest master. |
fmt.Printf("Executing: " + strings.Join(cmd.Args, " ") + "\n") | ||
|
||
// Run the command. | ||
if err := cmd.Run(); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you set the stdout and stderr here? It works but I see no logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can definitely do that. Are there some guidelines as to how std out/err should be managed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some simple redirection of stdout and stderr.
I have also added the capability to include environment variables in modeline options: test.yaml
When the modeline option is extracted, it will be added to the command line like this:
If the variable is not exported or has no value an error will be thrown. |
6ff3c96
to
cf7e640
Compare
Rebased on latest master. |
This patch adds command line options for creating, building and running local images.
A new local command,
local create
has been added to construct images.The first image kind it can produce is a base image to be used as a starter for all integration images. Example of building a base image, the image will be saved under the default name of
integration-base-image
:The image can then be used as a base for creating and building integration images, the image will be used automatically every time an integration image is created. If a base image isn't available it will be created automatically. Example of building an integration image (without running it):
The resulting image can then be run locally using the following invocation:
Local run has been enhanced with containerization capabilities i.e. it can now create, build and run container images locally. The following command containerizes and runs the integration (i.e. performs all previous steps automatically: base image creation and building, integration image creation and building, integration image running):
Release Note