Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first Knative trait and profiles #210

Merged
merged 3 commits into from
Nov 9, 2018

Conversation

nicolaferraro
Copy link
Member

kamel install now understands if Knative is installed in the cluster and automatically activates the Knative profile (list of traits to be enabled) and installs additional roles and bindings for the operator.

When using the Knative profile, a Knative Service is created instead of a Deployment. Later on we will add support for other kind of resources, such as EventSources.

The bad thing about the approach is that Knative serving CRD don't support mounting volumes (including configmaps) in order to wrap all the state in a single resource.
For this reason, I push the code into an ENV variable... not pretty... but I couldn't find a better solution that didn't include building a new image...

@lburgazzoli
Copy link
Contributor

can we access config maps through k8s api ?

@nicolaferraro
Copy link
Member Author

Mmh, no. Each time you do a deployment in Knative, you add a revision ad it should be self contained because you're able to change Istio routes to load-balance old revisions too.

If we keep the configmap separated, no matter the technology you use to load it, you're flattening all revisions to latest version.

So, I think the way to go is to make some changes in Knative serving to add better support for "configuration files".

@lburgazzoli lburgazzoli merged commit 28fa600 into apache:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants