new builder #223
new builder #223
Conversation
pkg/builder/builder_steps.go
Outdated
| //TODO: camel version should be retrieved from an external request or provided as static version | ||
| GroupID: "org.apache.camel", | ||
| ArtifactID: "camel-bom", | ||
| Version: "2.22.1", |
There was a problem hiding this comment.
I think we switched to "2.22.2"
| return request.Steps[i].Phase() < request.Steps[j].Phase() | ||
| }) | ||
|
|
||
| for _, step := range request.Steps { |
There was a problem hiding this comment.
So this means that the phases are no more interleaved, so a full build needs to be completed before a new one is started.
It solves also the problem of the initial contexts not being based one on another sometimes (e.g. randomly the Groovy context is not based on the JVM one)
There was a problem hiding this comment.
I see you've added this to the next things to do, but I'm not sure if it helps using the old strategy...
There was a problem hiding this comment.
Yes a full build is needed now, it is much simpler and it avoid clashes as you said. About parallel build, yeah, I'm not sure they are needed, so let's keep it simple for the moment.
lburgazzoli
force-pushed
the
build-manager
branch
from
c1cc947 to
82133ed
Compare
|
@nicolaferraro fixed, should bre ready to merge |
This PR is aimed to introduce a flexible builder to accommodate different build needs without having to introduces conditional paths in the current build manager.
Next step are: