chore: regenerated resources.go #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could it be that the generation iterates of the hash map ? (so with undeterministic order) |
|
never had this issue, the generator is a bash script scripts/embed_resources.sh |
|
Not sure what went wrong but in the checked in .go code its "crd-integration-context.yaml" before "cr-example.yaml", which is not in alphabetical order. |
|
maybe it was the result of a merge |
... and ensure that the resources are picked up in alphabetical order
rhuss
force-pushed
the
pr/resource-regen
branch
from
105f779 to
af12e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether this is white-space diff only. But if so, the generation should
be fixed to yield the same format on every platform.