-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trait): Move addon Telemetry to traits #5814
feat(trait): Move addon Telemetry to traits #5814
Conversation
1fd750b
to
84750ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think you need to check how the kamel run
would convert to an addons spec or to an trait spec.
5fe217a
to
f16e0cc
Compare
@@ -438,6 +438,7 @@ func TestConfigureTraits(t *testing.T) { | |||
"--trait", "affinity.pod-affinity=false", | |||
"--trait", "environment.container-meta=false", | |||
"--trait", "prometheus.pod-monitor=false", | |||
"--trait", "telemetry.auto=true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@squakez That was the point of this change to test is the run command really creates a trait and not an addon.
f16e0cc
to
521bd4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I miss is some deprecation notice in the Integration which is using the addons. Ideally, when executing the trait logic, it should be reported as an Integration condition as it happens for instance here:
Line 98 in a664283
condition = newOrAppend(condition, "Spectrum publishing strategy is deprecated and may be removed in future releases. Make sure to use any supported publishing strategy instead.") |
0df7f8d
to
73ca2f5
Compare
return true, nil, nil | ||
var condition *TraitCondition | ||
|
||
if _, isAddon := e.Integration.Spec.Traits.Addons["telemetry"]; isAddon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we also need to add a // Deprecated
comment as it's the way I usually scan code for deprecations to be eventually removed.
73ca2f5
to
00c253f
Compare
Ref #5787
Release Note