Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #41 Re-introduce test scope in integration test projects #140

Closed
wants to merge 1 commit into from

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Aug 16, 2019

@aloubyansky could you please review and eventually test if this works for you?

@asf-ci
Copy link

asf-ci commented Aug 16, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/93/

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 19, 2019

@aloubyansky we'd need to get this merged to avoid potential conflicts, but you are welcome to test or give feedback anyway. If you could please file a new issue if something does not work for you.

@aloubyansky
Copy link
Contributor

The first issue is

[WARNING] The POM for org.apache.camel.quarkus:camel-quarkus-integration-test-core-tests:jar:0.1.1-SNAPSHOT is invalid, transitive dependencies (if any) will not be available: 1 problem was encountered while building the effective model for org.apache.camel.quarkus:camel-quarkus-integration-test-core-tests:0.1.1-SNAPSHOT
[ERROR] 'dependencies.dependency.version' for org.apache.camel.quarkus:camel-quarkus-integration-test-core:jar is missing. @ 

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 19, 2019

How can I reproduce that error message?

@aloubyansky
Copy link
Contributor

mvn dependency:tree

@aloubyansky
Copy link
Contributor

I did it for the artifact that depended on the *-tests.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 19, 2019

You need to run mvn clean install -DskipTests on this PR's tree, which you did, I assume. It installs all tests jars except for the servlet one (because servlet has a different parent than the others). Did you happen to use the servlet itest in your experiment?

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 19, 2019

I am blind, your error message says you used core.

@ppalaga ppalaga force-pushed the 190816-test-artifacts branch from 53efad1 to e7622d7 Compare August 19, 2019 11:50
@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 19, 2019

e7622d7 fixes the problem reported by @aloubyansky (thanks!)

@asf-ci
Copy link

asf-ci commented Aug 19, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/96/

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 20, 2019

Replaced by #150

@ppalaga ppalaga closed this Aug 20, 2019
@aloubyansky
Copy link
Contributor

A class in Quarkus needs a one line adjustment for this approach to work.

@aloubyansky
Copy link
Contributor

quarkusio/quarkus#3615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants