-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up usage of hard coded hosts that use containers #5509
Clean up usage of hard coded hosts that use containers #5509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also needs to do in PahoMqtt5TestResource.java
Lines 80 to 81 in 5f4d5b3
result = CollectionHelper.mapOf( | |
"paho5.broker.tcp.url", "tcp://localhost:" + port); |
Lines 102 to 109 in 5f4d5b3
if (!useFixedPort) { | |
result = CollectionHelper.mapOf( | |
"camel.component.paho-mqtt5.username", MQTT_USERNAME, | |
"camel.component.paho-mqtt5.password", MQTT_PASSWORD, | |
"paho5.broker.tcp.url", String.format("tcp://localhost:%d", container.getMappedPort(TCP_PORT)), | |
"paho5.broker.ssl.url", String.format("ssl://localhost:%d", container.getMappedPort(SSL_PORT)), | |
"paho5.broker.ws.url", String.format("ws://localhost:%d", container.getMappedPort(WS_PORT))); | |
} |
96ef942
to
75823cc
Compare
Thanks, I made work like the other paho test. The downside is that when using a custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense.
@@ -15,3 +15,6 @@ | |||
## limitations under the License. | |||
## --------------------------------------------------------------------------- | |||
quarkus.native.resources.includes=*.jks | |||
|
|||
# Required by NetworkModuleService.setURIField | |||
quarkus.native.additional-build-args=-J--add-opens=java.base/java.net=ALL-UNNAMED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add some notes in docs of paho-mqtt5
? is it only needed in ssl cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back to look at it again. And the test is actually passing without it.
Maybe I previously had something misconfigured that triggered the problem code in NetworkModuleService
.
I can revert the --add-opens
and create follow up issue to investigate further as there's potentially an issue there for some scenarios (to be verified). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it looks good to me.
75823cc
to
80b7cdb
Compare
…rtificate files could not be deleted
80b7cdb
to
e6896d0
Compare
No description provided.