Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent failure of debug integration test #5531

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix intermittent failure of debug integration test #5531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions integration-tests/debug/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.awaitility</groupId>
<artifactId>awaitility</artifactId>
<scope>test</scope>
</dependency>
</dependencies>

<profiles>
Expand Down
75 changes: 39 additions & 36 deletions ...tion-tests/debug/src/test/java/org/apache/camel/quarkus/component/debug/it/DebugTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.util.Iterator;
import java.util.Set;
import java.util.concurrent.TimeUnit;

import javax.management.JMX;
import javax.management.MBeanServerConnection;
Expand All @@ -32,19 +33,17 @@
import org.apache.camel.ServiceStatus;
import org.apache.camel.api.management.mbean.ManagedBacklogDebuggerMBean;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledOnOs;
import org.junit.jupiter.api.condition.OS;

import static org.apache.camel.component.debug.JmxConnectorService.DEFAULT_HOST;
import static org.apache.camel.component.debug.JmxConnectorService.DEFAULT_REGISTRY_PORT;
import static org.apache.camel.component.debug.JmxConnectorService.DEFAULT_SERVICE_URL_PATH;
import static org.awaitility.Awaitility.await;
import static org.hamcrest.Matchers.is;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.fail;

@QuarkusTest
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/apache/camel-quarkus/issues/5443")
public class DebugTest {

@Test
Expand All @@ -61,25 +60,27 @@ void camelDebugJmxConnection() throws Exception {
DEFAULT_SERVICE_URL_PATH);
JMXServiceURL jmxUrl = new JMXServiceURL(url);

try (JMXConnector connector = JMXConnectorFactory.connect(jmxUrl)) {
MBeanServerConnection mbeanServer = connector.getMBeanServerConnection();
await().pollInterval(50, TimeUnit.MILLISECONDS).atMost(10, TimeUnit.SECONDS).untilAsserted(() -> {
try (JMXConnector connector = JMXConnectorFactory.connect(jmxUrl)) {
MBeanServerConnection mbeanServer = connector.getMBeanServerConnection();

ObjectName objectName = new ObjectName("org.apache.camel:type=context,*");
Set<ObjectInstance> mbeans = mbeanServer.queryMBeans(objectName, null);
assertNotNull(mbeans);
ObjectName objectName = new ObjectName("org.apache.camel:type=context,*");
Set<ObjectInstance> mbeans = mbeanServer.queryMBeans(objectName, null);
assertNotNull(mbeans);

Iterator<ObjectInstance> iterator = mbeans.iterator();
if (iterator.hasNext()) {
ObjectInstance camelContext = iterator.next();
assertNotNull(camelContext);
Iterator<ObjectInstance> iterator = mbeans.iterator();
if (iterator.hasNext()) {
ObjectInstance camelContext = iterator.next();
assertNotNull(camelContext);

String status = (String) mbeanServer.invoke(camelContext.getObjectName(), "getState", new Object[] {},
new String[] {});
assertEquals(ServiceStatus.Started, ServiceStatus.valueOf(status));
} else {
fail("Expected to find 1 CamelContext MBean");
String status = (String) mbeanServer.invoke(camelContext.getObjectName(), "getState", new Object[] {},
new String[] {});
assertEquals(ServiceStatus.Started, ServiceStatus.valueOf(status));
} else {
fail("Expected to find 1 CamelContext MBean");
}
}
}
});
}

@Test
Expand All @@ -88,26 +89,28 @@ void accessToBacklogDebugger() throws Exception {
DEFAULT_SERVICE_URL_PATH);
JMXServiceURL jmxUrl = new JMXServiceURL(url);

try (JMXConnector connector = JMXConnectorFactory.connect(jmxUrl)) {
MBeanServerConnection mbeanServer = connector.getMBeanServerConnection();
await().pollInterval(50, TimeUnit.MILLISECONDS).atMost(10, TimeUnit.SECONDS).untilAsserted(() -> {
try (JMXConnector connector = JMXConnectorFactory.connect(jmxUrl)) {
MBeanServerConnection mbeanServer = connector.getMBeanServerConnection();

ObjectName objectName = new ObjectName("org.apache.camel:context=*,type=tracer,name=BacklogDebugger");
Set<ObjectName> names = mbeanServer.queryNames(objectName, null);
assertNotNull(names);
ObjectName objectName = new ObjectName("org.apache.camel:context=*,type=tracer,name=BacklogDebugger");
Set<ObjectName> names = mbeanServer.queryNames(objectName, null);
assertNotNull(names);

Iterator<ObjectName> iteratorNames = names.iterator();
if (iteratorNames.hasNext()) {
ObjectName debuggerMBeanObjectName = iteratorNames.next();
assertNotNull(debuggerMBeanObjectName);
ManagedBacklogDebuggerMBean backlogDebugger = JMX.newMBeanProxy(mbeanServer, debuggerMBeanObjectName,
ManagedBacklogDebuggerMBean.class);
Set<String> breakpoints = backlogDebugger.breakpoints();
assertNotNull(breakpoints);
Set<String> suspendedBreakpointNodeIds = backlogDebugger.suspendedBreakpointNodeIds();
assertNotNull(suspendedBreakpointNodeIds);
} else {
fail("Expected to find 1 BacklogDebugger");
Iterator<ObjectName> iteratorNames = names.iterator();
if (iteratorNames.hasNext()) {
ObjectName debuggerMBeanObjectName = iteratorNames.next();
assertNotNull(debuggerMBeanObjectName);
ManagedBacklogDebuggerMBean backlogDebugger = JMX.newMBeanProxy(mbeanServer, debuggerMBeanObjectName,
ManagedBacklogDebuggerMBean.class);
Set<String> breakpoints = backlogDebugger.breakpoints();
assertNotNull(breakpoints);
Set<String> suspendedBreakpointNodeIds = backlogDebugger.suspendedBreakpointNodeIds();
assertNotNull(suspendedBreakpointNodeIds);
} else {
fail("Expected to find 1 BacklogDebugger");
}
}
}
});
}
}