-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinispan test suite integration changes #5719
Conversation
I don't know who else I should ping here @jamesnetherton @zbendhiba |
...org/apache/camel/quarkus/component/infinispan/common/InfinispanCommonServerTestResource.java
Outdated
Show resolved
Hide resolved
...org/apache/camel/quarkus/component/infinispan/common/InfinispanCommonServerTestResource.java
Outdated
Show resolved
Hide resolved
f5952c9
to
049bea8
Compare
049bea8
to
867deba
Compare
@jamesnetherton I made tests work locally, but I did not build everything. Let me know what you think about these changes please |
...rc/test/java/org/apache/camel/quarkus/component/infinispan/InfinispanServerTestResource.java
Outdated
Show resolved
Hide resolved
867deba
to
0c39b6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some missing license headers.
Please also ensure the code formatting Maven mojos are run. If you cd
into integration-tests/infinispan-quarkus-client
& integration-tests/infinispan
and just run the build with mvn clean install -DskipTests
you should see that some files got reformatted, so just commit them.
integration-tests/infinispan-quarkus-client/src/main/resources/camel-infinispan-cache.xml
Outdated
Show resolved
Hide resolved
integration-tests/infinispan/src/main/resources/camel-infinispan-cache.xml
Outdated
Show resolved
Hide resolved
0c39b6d
to
6b34fdc
Compare
Seems there's an NPE in native mode:
|
ahh yes, I'll add the missing config |
@jamesnetherton I'm going to simplify something |
6b34fdc
to
6be8ced
Compare
...infinispan/src/main/java/org/apache/camel/quarkus/component/infinispan/InfinispanRoutes.java
Show resolved
Hide resolved
...c/main/java/org/apache/camel/quarkus/component/infinispan/common/InfinispanCommonRoutes.java
Show resolved
Hide resolved
@jamesnetherton look good now |
Thanks a lot for this @karesti. |
Many thanks @karesti ! |
I changed the code to use dev services
for night builds, you might replace dev services image by replacing the https://quarkus.io/guides/infinispan-dev-services#quarkus-infinispan-client-config-group-infinispan-client-build-time-config-dev-service-configuration_quarkus-infinispan-client-devservices-image-name
If you need to override something on the server configuration, you can do it in further versions by using the overriding capabilities
quarkusio/quarkus#38642