-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jt400: possible missing resource in the native #6030
Jt400: possible missing resource in the native #6030
Conversation
...oyment/src/main/java/org/apache/camel/quarkus/component/jt400/deployment/Jt400Processor.java
Show resolved
Hide resolved
@JiriOndrusek is it possible to add an unit test? |
38e388c
to
88f676e
Compare
I'm thinking about that, I can try. Although the test would cover a scenario which does not make sense |
88f676e
to
add9904
Compare
@zhfeng test is added |
@zhfeng I have to check again, whether the added test can not affect existing one when executed in different order |
eb1e63f
to
4d352f9
Compare
I run the tests ordered with new method at the first place and at last place and there was no issue. |
@jamesnetherton As I think about the test coverage, it makes sense to me to move the test into Of course I have to try , whether it is possible). WDYT. |
Sounds ok to me. Or if we need to have it duplicated in both mocked and non-mocked, that's fine too. |
Duplication (even if should be avoided) sounds like the right solution |
4d352f9
to
1a446ee
Compare
I added the new test intojt400-mocked (as duplication) |
fixes #6029