Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-16787: Align apache-any23 version with version in parent pom #6783

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

skepticoitusInteruptus
Copy link
Contributor

This proposed file change is kind of related to "3rd party dependency or pom.xml refers to bintray".

It is not obvious exactly which artifacts in Camel's dependency graph have a transient dependency on org.apache.any23:apache-any23:2.4

For some reason or another though, at least three dependencies trigger an attempt to download org.apache.any23:apache-any23:2.4:

  1. com.google.guava:guava
  2. com.google.code.findbugs:jsr305
  3. org.slf4j:slf4j-api

Those download attempts try to resolve apache-any23:2.4's pom. That pom is configured with a bintray repository that is unreachable.

That unreachable bintray repository has been removed from org.apache.any23:apache-any23:2.6.

This pull request proposes that camel-dependencies-pom-template.xml be upgraded from apache-any23:2.4 to 2.6like the parent/pom.xml was.

That previous upgrade to apache-any23:2.6 in the parent pom will have resolved the WARNING reported in 16787.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be done each time you build the project. The camel-dependencies module will be updated and attached to the build, with the versions aligned to what is in parent pom. This update won't have effect, because all the magic happens at build time.

@skepticoitusInteruptus
Copy link
Contributor Author

Will try to loop @lewismc or @Yongyao in; for their Any23 insider's insight.

@oscerd
Copy link
Contributor

oscerd commented Jan 19, 2022

It's not related to person internal to any23, it's how the Camel build works. Each time you run a full build camel dependencies module will be attached to the Snapshot, what you see in the actual template doesn't reflect the snapshot build.

@lewismc
Copy link
Member

lewismc commented Jan 20, 2022

@oscerd correct.
I will state that there are no API-breaking changes between Any23 2.4-->2.6 so you should be just fine with the dependency upgrade. I'll also note that Any23 dependency chain has been updated to address several CVE's recently so thanks for upgrading in Camel :)

@davsclaus davsclaus merged commit 8114431 into apache:main Jan 20, 2022
bvfalcon pushed a commit to bvfalcon/apache-camel-jakarta-ee that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants