nit: remove synchornized

apache · Dec 20, 2024 · 6d1b4ad · 6d1b4ad
1 parent 4ae7cee
commit 6d1b4ad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java b/client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
@@ -258,7 +258,7 @@ protected static List<TaskInfo> getTaskAttempts(TaskSetManager taskSetManager, l
     }
   }
 
-  public static synchronized boolean taskAnotherAttemptRunningOrSuccessful(long taskId) {
+  public static boolean taskAnotherAttemptRunningOrSuccessful(long taskId) {
     TaskSetManager taskSetManager = getTaskSetManager(taskId);
     if (taskSetManager != null) {
       int stageId = taskSetManager.stageId();
@@ -272,7 +272,7 @@ public static synchronized boolean taskAnotherAttemptRunningOrSuccessful(long ta
           if (ti.taskId() != taskId) {
             if (ti.successful()) {
               LOG.info(
-                  "StageId={} index={} taskId={} attempt={} another attempt {} is finished.",
+                  "StageId={} index={} taskId={} attempt={} another attempt {} is successful.",
                   stageId,
                   taskIndex,
                   taskId,

diff --git a/client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java b/client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
@@ -374,7 +374,7 @@ protected static List<TaskInfo> getTaskAttempts(TaskSetManager taskSetManager, l
     }
   }
 
-  public static synchronized boolean taskAnotherAttemptRunningOrSuccessful(long taskId) {
+  public static boolean taskAnotherAttemptRunningOrSuccessful(long taskId) {
     TaskSetManager taskSetManager = getTaskSetManager(taskId);
     if (taskSetManager != null) {
       int stageId = taskSetManager.stageId();
@@ -388,7 +388,7 @@ public static synchronized boolean taskAnotherAttemptRunningOrSuccessful(long ta
           if (ti.taskId() != taskId) {
             if (ti.successful()) {
               LOG.info(
-                  "StageId={} index={} taskId={} attempt={} another attempt {} is finished.",
+                  "StageId={} index={} taskId={} attempt={} another attempt {} is successful.",
                   stageId,
                   taskIndex,
                   taskId,