[BUG] ClusterLoadFallbackPolicy is not strictness when a shuffle with big partitions to register #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -31,7 +31,8 @@ class RssShuffleFallbackPolicyRunner(sparkConf: SparkConf) extends Logging { | |||
| def applyAllFallbackPolicy(dependency: ShuffleDependency[_, _, _], | |||
There was a problem hiding this comment.
dependency.partitioner.numPartitions seems enough, could you please help to optimize this？Thanks
There was a problem hiding this comment.
Yes, I have retrieved the param [dependency] from this function
| private def handleGetClusterLoadStatus(context: RpcCallContext): Unit = { | ||
| val (_, _, _, result) = getClusterLoad | ||
| private def handleGetClusterLoadStatus(context: RpcCallContext, numPartitions: Int): Unit = { | ||
| val (_, _, _, result) = getClusterLoad(numPartitions) |
There was a problem hiding this comment.
Why we need so much return values, please remove useless return
There was a problem hiding this comment.
The [getClusterLoad] is common function, we may need the top three return-values in the other place. I can separate the value through creating new function.
|
LGTM |
server-master/src/main/scala/com/aliyun/emr/rss/service/deploy/master/Master.scala
Outdated
Show resolved
Hide resolved
...e-manager-3/src/main/scala/org/apache/spark/shuffle/rss/RssShuffleFallbackPolicyRunner.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] ClusterLoadFallbackPolicy is not strictness when a shuffle with big partitions to register
What changes were proposed in this pull request?
If a shuffle with 5w partitions to register, and cluster has 3w but the slots usage is not in high load status, 5w allocation slots will failed.
Why are the changes needed?
This change will avoid this circumstance that a shuffle that it will cost too much slots over clusters' continues process of RSS handling
What are the items that need reviewer attention?
Related issues.
#17
Related pull requests.
How was this patch tested?
/cc @FMX
/assign @wangshengjie