[CELEBORN-1794] Fix TestCongestionController occasional failing #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
approved these changes
Dec 20, 2024
RexXiong
reviewed
Dec 23, 2024
| @@ -298,6 +299,11 @@ public void close() { | |||
| this.producedBufferStatusHub.clear(); | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| public void shutDownCheckService() { | |||
| this.checkService.shutdownNow(); | |||
RexXiong
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
There are a small probability of the TestCongestionController test failing.
That is because the
checkServicewill excute once it was init, which can cause a multithreading conflict with the test code.What changes were proposed in this pull request?
Fix ut bug.
In fact,
shutDownCheckServicestill wont prevent thecheckServicefrom excuting at once but can make the main testing thread waiting for it to shutDown.Does this PR introduce any user-facing change?
No.
How was this patch tested?
manual test.