Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1783][FOLLOWUP][0.4] Compatible with UT #3024

Closed
wants to merge 1 commit into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Dec 23, 2024

What changes were proposed in this pull request?

Compatible with UT for branch-0.4, followup de436f7

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@turboFei turboFei marked this pull request as draft December 23, 2024 07:36
@turboFei turboFei changed the title [CELEBORN-1783][FOLLOWUP][0.4] Fix UT [CELEBORN-1783][FOLLOWUP][0.4] Compatible with UT Dec 23, 2024
@turboFei turboFei force-pushed the branch-0.4_ut branch 2 times, most recently from 7d2651b to e2d9734 Compare December 23, 2024 07:46
@turboFei turboFei marked this pull request as ready for review December 23, 2024 07:46
@turboFei
Copy link
Member Author

UT passed, cc @RexXiong

Copy link
Contributor

@RexXiong RexXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turboFei , merge to branch-0.4(v0.4.4)

RexXiong pushed a commit that referenced this pull request Dec 24, 2024
### What changes were proposed in this pull request?

Compatible with UT for branch-0.4, followup de436f7

### Why are the changes needed?

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Closes #3024 from turboFei/branch-0.4_ut.

Authored-by: Wang, Fei <[email protected]>
Signed-off-by: Shuang <[email protected]>
@turboFei turboFei closed this Dec 24, 2024
@turboFei turboFei deleted the branch-0.4_ut branch December 24, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants