[CELEBORN-1835][CIP-8] Add tier writer base and memory tier writer #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RexXiong
reviewed
Jan 17, 2025
| } | ||
| waitTime -= WAIT_INTERVAL_MS | ||
| } | ||
| if (counter.get > 0) { |
There was a problem hiding this comment.
numPendingWrites can bypass counter.get>0
| flushBuffer = inputBuffer | ||
| } | ||
|
|
||
| def close(evict: Boolean = false): Long = { |
There was a problem hiding this comment.
should we synchronized when close?
| metaHandler.beforeWrite(buf) | ||
| ensureNotClosed() | ||
| writerInternal(buf) | ||
| updateMemoryMetric(buf.readableBytes) |
There was a problem hiding this comment.
move updateMemoryMetric to MemoryTierWriter
| val dupBuf = flushBuffer.retainedDuplicate() | ||
| // this flusher buffer is from memory tier writer, so that we can not keep the buffer | ||
| flushTask = genFlushTask(finalFlush, false) | ||
| MemoryManager.instance.releaseMemoryFileStorage(numBytes) |
There was a problem hiding this comment.
move to MemoryTierWriter, releaseMemoryFileStorage and incrementDiskBuffer after evict finished
RexXiong
reviewed
Jan 22, 2025
| storageManager) { | ||
|
|
||
| override def needEvict(): Boolean = { | ||
| flushBuffer.readableBytes() > memoryFileStorageMaxFileSize && storageManager.localOrDfsStorageAvailable() |
There was a problem hiding this comment.
lazy val for storageManager.localOrDfsStorageAvailable()
|
|
||
| protected def writerInternal(buf: ByteBuf): Unit | ||
|
|
||
| def updateMemoryMetric(numBytes: Int): Unit |
There was a problem hiding this comment.
updateMemoryMetric can be removed.
RexXiong
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Code coverage report:
NOTE:
Evict test needs file tier writer, so the branch coverage is not 100% in the memory tier.
Why are the changes needed?
Refactor partition data writer for CIP-8.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
GA.