[CELEBORN-1836][CIP-14] Add Message to cppClient #3066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RexXiong
reviewed
Jan 17, 2025
cpp/celeborn/network/Message.cpp
Outdated
| } | ||
| } | ||
|
|
||
| std::atomic<long> Message::currRequestId_ = 1000; |
There was a problem hiding this comment.
This is a typo mistake when testing, refactored to start from 0.
|
Thanks merge to main(v0.6.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds Message implementation to cppClient.
Why are the changes needed?
The Message is the data structure that transfers between network stack layers.
The decode/encode methods are supported and are compatible with existing java implementation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and UTs.