[ISSUE-607]Add map ids info for each PartitionLocation to enable filtering for m… #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FMX
force-pushed
the
607-featureoptimize-add-map-ids-info-for-each-partitionlocation-to-enable-filtering-for-map-range-reading
branch
from
fc6c340 to
bbe0210
Compare
|
We should add metrics about the size of the RoaringBitmap for very large partitions and post here. |
| return true; | ||
| } | ||
| for (int i = startMapIndex; i < endMapIndex; i++) { | ||
| hasMapId = hasMapId | location.getMapIdBitMap().contains(i); |
There was a problem hiding this comment.
Delete hasMapId and rewrite to
if (location.getMapIdBitMap().contains(i)) {
return true;
}
| locationCount); | ||
| while (!currentReader.hasNext() && fileIndex < locationCount - 1) { | ||
| while (!locationHasMapIdToRead(startMapIndex, endMapIndex, currentLocation) | ||
| && fileIndex < locationCount - 1) { |
There was a problem hiding this comment.
Remove fileIndex < locationCount - 1 from the condition
| locationCount); | ||
| while (!currentReader.hasNext() && fileIndex < locationCount - 1) { | ||
| while (!locationHasMapIdToRead(startMapIndex, endMapIndex, currentLocation) | ||
| && fileIndex < locationCount - 1) { | ||
| fileIndex++; |
There was a problem hiding this comment.
if (fileIndex == locationCount) {
break;
}
| if (currentReader.hasNext()) { | ||
| currentChunk = currentReader.next(); | ||
| fileIndex++; | ||
| if (((fileIndex == (locationCount - 1)) |
There was a problem hiding this comment.
if (fileIndex < locationCount) {
return currentLocation;
} else {
return null;
}
| if (currentLocation == null) { | ||
| return; | ||
| } | ||
| currentReader = createReader(currentLocation); |
There was a problem hiding this comment.
Why delete the following logic? For normal read we don't know if currentReader has chunks.
while (!currentReader.hasNext()...)
| private void moveToNextReader() throws IOException { | ||
| if (currentReader != null) { | ||
| currentReader.close(); | ||
| private boolean locationHasMapIdToRead( |
There was a problem hiding this comment.
Better to rename to skipLocation, and return true if we are guaranteed that the location has no data to read.
…h-partitionlocation-to-enable-filtering-for-map-range-reading
FMX
deleted the
607-featureoptimize-add-map-ids-info-for-each-partitionlocation-to-enable-filtering-for-map-range-reading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ap range reading
[FEATURE]Add map ids info for each PartitionLocation to enable filtering for m…
What changes were proposed in this pull request?
Why are the changes needed?
What are the items that need reviewer attention?
Related issues.
closes #607
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer