Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commons-lang3 optional #489

Closed
wants to merge 1 commit into from
Closed

Make commons-lang3 optional #489

wants to merge 1 commit into from

Conversation

basil
Copy link

@basil basil commented Feb 27, 2024

Jenkins core ships commons-compress (where it is available to all Jenkins plugins) for historical reasons, but not commons-lang3. Instead we prefer to deliver commons-lang3 through the Jenkins plugin system. commons-compress has recently sprouted a dependency on commons-lang3, which has forced us to start delivering commons-lang3 in core, which we don't want to do. This library is only used in org.apache.commons.compress.harmony.unpack200.Pack200UnpackerAdapter which we don't use anyway, so make this an optional dependency. People who use Pack200UnpackerAdapter can include it, but those of us who would rather avoid it can do without.

@garydgregory
Copy link
Member

garydgregory commented Feb 27, 2024

-1: We are moving away from using Maven optional dependencies. If you know that a code path will never hit a dependency, you can exclude it I suppose.

@basil
Copy link
Author

basil commented Feb 27, 2024

I have done that in jenkinsci/jenkins#8997. Maybe you can find a way to do without FieldUtils in src/main and then convert it to a test-scoped dependency.

@garydgregory
Copy link
Member

Closing: Information provided; see #490 for a possible alternate path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants