Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14098: Remove unused res folder #21

Merged
merged 1 commit into from
May 21, 2018
Merged

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented May 18, 2018

Platforms affected

All

What does this PR do?

Remove unused icons and splash screens from this template to save 10MiB in every cordova project created from it and every installation of cordova (that's two thirds of cordova's package size).

What testing has been done on this change?

Manual. I can create a new project with this, add platform android and run it. Has no obviously missing assets. Plus, I can confirm that cordova-create never uses this folder for anything.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@Menardi
Copy link

Menardi commented May 20, 2018

I agree, it looks like the res folder is redundant. An iOS app built on this template is just fine, and has all the default Cordova icons. I'm not sure where they're being taken from, but it's not this res folder.

@raphinesse
Copy link
Contributor Author

raphinesse commented May 21, 2018

@Menardi Thanks for testing. The former README in this folder says:

Although there are default image resources in a newly-created project, those come from the platform-specific project template, which can generally be found in the platform's template directory.

@shazron
Copy link
Member

shazron commented May 21, 2018

iOS images are in this bundle, which is in the platform template: https://github.com/apache/cordova-ios/tree/3507af4ac68ed13cfb4d8ecfd0e91e747a9c6875/bin/templates/project/__PROJECT_NAME__/Images.xcassets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants