Drop support for reading from .cordova/config.json #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting this change does not break any existing tests in the spec suite. +1 for removing such untested functionality, if properly documented, from major release. |
|
AFAIK, this functionality was neither tested nor documented. So IMO mentioning in the release notes for the next major release should suffice. |
|
Agreed on my part, yes
On Jun 3, 2018 7:31 PM, "Raphael von der Grün" <[email protected]> wrote:
AFAIK, this functionality was neither tested nor documented. So IMO
mentioning in the release notes for the next major release should suffice.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves §2 from apache/cordova-discuss/issues/89