chore!: Remove podspec support from framework tag #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been deprecated in favour of the <podspec> tag that allows much more control over pod dependencies. Closes apache#812.
Codecov Report
@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
- Coverage 78.62% 78.58% -0.04%
==========================================
Files 15 15
Lines 1801 1770 -31
==========================================
- Hits 1416 1391 -25
+ Misses 385 379 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
erisu
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Since this is a major release, I think it is safe to remove the deprecated framework tag's attribute podspec.
The new method <podspec> was introduced in [email protected] (Feb 07, 2019).
Plugin developers had 4 years to migrate to the new tag.
deanylev
added a commit
to viviedu/cordova-ios
that referenced
this pull request
Apr 24, 2024
This reverts commit 76e33d9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #812.
Platforms affected
iOS
Motivation and Context
<framework type="podspec">has been deprecated in favour of the<podspec>tag that allows much more control over pod dependencies.Description
Remove support for
<framework type="podspec">and print an error if such framework tags are found.Testing
Removed unit tests around special case handling for podspec framework tags.
Checklist