-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-9789: Support setting the default app locale #237
Conversation
Current coverage is 53.50% (diff: 50.00%)@@ master #237 diff @@
==========================================
Files 12 12
Lines 1026 1028 +2
Methods 145 145
Messages 0 0
Branches 168 169 +1
==========================================
+ Hits 549 550 +1
- Misses 477 478 +1
Partials 0 0
|
Can you create a new issue for the language thing and link it instead of CB-9789? Are there issues open for the cleanIcons and cleanSplashScreens bugs? Tests are failing because |
The |
apache/cordova-lib#466 has been merged and should be in cordova-common 1.4.1 when it is released (we need to update the bundled cordova-common in this repo) |
cordova-common 1.4.1 has been bundled in master, and this PR now fails one unit-test (
|
@shazron Thanks, I've rebased on master and updated the tests |
@dpogue Please send a PR for a docs update as well. |
This allows customizing the default language of the application on iOS. Ref CB-9789 See also apache/cordova-ios#237
This allows customizing the default language of the application on iOS. Ref CB-9789 See also apache/cordova-ios#237 This closes #627
This allows adding a
defaultlocale="XX"
attribute to thewidget
tag in config.xml to set the CFBundleDevelopmentRegion to a different language. This allows native UI (like the camera plugin) to use a non-English locale.Requires apache/cordova-lib#466
References apache/cordova-discuss#25
/cc @jasongin for the bugfix in
cleanIcons
andcleanSplashScreens