Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-9789: Support setting the default app locale #237

Closed
wants to merge 2 commits into from

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Jul 22, 2016

This allows adding a defaultlocale="XX" attribute to the widget tag in config.xml to set the CFBundleDevelopmentRegion to a different language. This allows native UI (like the camera plugin) to use a non-English locale.

Requires apache/cordova-lib#466
References apache/cordova-discuss#25

/cc @jasongin for the bugfix in cleanIcons and cleanSplashScreens

@codecov-io
Copy link

codecov-io commented Jul 22, 2016

Current coverage is 53.50% (diff: 50.00%)

Merging #237 into master will decrease coverage by <.01%

@@             master       #237   diff @@
==========================================
  Files            12         12          
  Lines          1026       1028     +2   
  Methods         145        145          
  Messages          0          0          
  Branches        168        169     +1   
==========================================
+ Hits            549        550     +1   
- Misses          477        478     +1   
  Partials          0          0          

Powered by Codecov. Last update c245535...1976afb

@jcesarmobile
Copy link
Member

Can you create a new issue for the language thing and link it instead of CB-9789?
And push only the code related to that.

Are there issues open for the cleanIcons and cleanSplashScreens bugs?

Tests are failing because has no method 'getAttribute'

@dpogue
Copy link
Member Author

dpogue commented Jul 25, 2016

The getAttribute method is implemented in apache/cordova-lib#466 (which isn't merged yet)

@shazron
Copy link
Member

shazron commented Aug 15, 2016

apache/cordova-lib#466 has been merged and should be in cordova-common 1.4.1 when it is released (we need to update the bundled cordova-common in this repo)

@shazron
Copy link
Member

shazron commented Aug 16, 2016

cordova-common 1.4.1 has been bundled in master, and this PR now fails one unit-test (npm run unit-tests):

Failures:

  1) prepare updateProject method should write out the app id to info plist as CFBundleIdentifier with ios-CFBundleIdentifier
   Message:
     Expected 'testpkg' to equal 'testpkg_ios'.
   Stacktrace:
     Error: Expected 'testpkg' to equal 'testpkg_ios'.
  at /Users/shaz/Documents/Git/Apache/cordova-ios/tests/spec/unit/prepare.spec.js:126:79
  at _fulfilled (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:834:54)
  at self.promiseDispatch.done (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:863:30)
  at Promise.promise.promiseDispatch (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:796:13)
  at /Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:556:49
  at runSingle (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:137:13)
  at flush (/Users/shaz/Documents/Git/Apache/cordova-ios/node_modules/q/q.js:125:13)
  at _combinedTickCallback (internal/process/next_tick.js:67:7)
  at process._tickCallback (internal/process/next_tick.js:98:9)

@dpogue
Copy link
Member Author

dpogue commented Aug 17, 2016

@shazron Thanks, I've rebased on master and updated the tests

@asfgit asfgit closed this in a06f419 Aug 17, 2016
@shazron
Copy link
Member

shazron commented Aug 17, 2016

@dpogue Please send a PR for a docs update as well.

dpogue added a commit to dpogue/cordova-docs that referenced this pull request Aug 17, 2016
This allows customizing the default language of the application on iOS.

Ref CB-9789
See also apache/cordova-ios#237
asfgit pushed a commit to apache/cordova-docs that referenced this pull request Aug 23, 2016
This allows customizing the default language of the application on iOS.

Ref CB-9789
See also apache/cordova-ios#237

 This closes #627
@dpogue dpogue deleted the defaultlocale branch August 23, 2016 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants