-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(android) fix: use provider prefix to avoid conflict with cordova-open plugin #510
(android) fix: use provider prefix to avoid conflict with cordova-open plugin #510
Conversation
Can this PR be merged please? It brakes the plugin on all Android devices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, just a few minor things I would change to avoid using general keywords that other libraries/plugins may also end up using.
Thank you for your speed 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, it looks good to me. I'd like to have at least one other positive vote by another PMC member before I merge.
Is there any chance this change is being merged soon? :) |
There is still an open discussion. I'm not merging something that I'm not 100% sure of that it does not cause a breaking change - unless it's explicitly stated so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
…viders (apache#510) Co-authored-by: jcesarmobile <[email protected]> (cherry picked from commit eb7fc33)
Platforms affected
cordova-android
Motivation and Context
Application crash when open the camera if
cordova-plugin-open
installed.Providers of
cordova-plugin-open
andcordova-plugin-camera
are in conflicts using the sameandroid:authorities
value. See the AndroidManifest:Fix: #416
Description
Add "camera" in the
android:authorities
to void namespace conflictTesting
Open camera, take a picture
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)