Bugfix issue 341 save to photo gallery - Fixes #341, fixes #577

[PieterVanPoyer]

Platforms affected

• Android

Motivation and Context

• Fixes Save Photo To Album - Android (not tested on iOS) #341
• Fixes SaveToPhotoAlbum does not save image on Android #577

The saveToPhotoAlbum setting throws an exception while using the camera. (sourceType = CAMERA)
This results in a crash of the application.
The first bug was reported in september 2018.
This PR only tries to solve the issue for the sourceType Camera.PictureSourceType.CAMERA, not for when the sourceType is PHOTOLIBRARY.
A reproduction of the issue can be done with https://github.com/PieterVanPoyer/cordova-camera-plugin-testing-app repo.

Description

• saveToPhotoAlbum feature fixed by taken into count content - uri. (writeUncompressedImage method) ( see: Cannot use saveToPhotoAlbum: true on Android 10 #611 (comment) )
• make saveToPhotoAlbum future proof by using the MediaStore to insert the taken image
• made a method to calculate the compressFormat based on the encodingType (JPEG or PNG)
• layout of the performCrop method is adjusted
• removed unused rotate variable inside processResultFromGallery method
• added a GalleryPathVO (ValueObject) for more easy working with the path and imagename.
• add extra VO class to the plugin.xml

Testing

I did run npm run test.
Tested on Android emulators from Android 5.1, 7, 10 and 11.
Tested on a real Samsung J7 device (Android 9), tested on a Samsung Galaxy tablet.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[PieterVanPoyer]

@erisu or @breautek can anybody review this PR, please?
The Travis build failed, but nothing was changed for the failed tests.

[breautek]

Travis is failling on browser tests, and considering this PR changes nothing in the browser platform, I don't think it's a blocker. It seems to be a timeout issue, so I'll close/reopen this PR to retrigger travis. Maybe that's all it is.

I had a glance at this PR and I don't see anything wrong, but I would like to spend some time to actually test on a physical device, but I don't think I can do that this week.

[PieterVanPoyer]

@erisu Hey, I hate to disturb you, but can you find the time to review this PR. Kind regards.

[PieterVanPoyer]

@breautek Hey it seems like erisu can not find the time to review this PR, maybe just merge it to the master? Or maybe we should request another reviewer?
Kind regards.

[breautek]

I'll give a 1 week call out.

If there are no objections by October 16 I'll merge.

[PieterVanPoyer]

I'll give a 1 week call out.

If there are no objections by October 16 I'll merge.

Sound like a great plan! Thanks.

[breautek]

Travis failures are unrelated to this PR. Merging now. Thank you @PieterVanPoyer for your time and effort in preparing this PR.