-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): supports sdk-30 package visibility #684
Conversation
I don’t think we should add this yet because cordova-android doesn’t support SDK 30. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you amend the commit message, it contains a typo :)
|
65c95fc
to
c0a4243
Compare
Personally as long as the changes aren't introducing breaking changes, I don't see why we shouldn't accept PRs that addresses issues in upcoming API levels. It help us stay ahead of the curve. |
Hello guys, may you please help with this error, when taking photos with cordova app Attempt to invoke virtual method 'boolean java.io.File.mkdirs()' on a null object reference. Please |
Hi . Is there any ETA for a release of this? It's not possible to use camera while target SDK 30, but Google now refuse apps (updates or new ones), that do not the SDK 30, so basically camera plugin do not work anymore on Android 11 to publish a public app. Thank you! |
We cannot provide ETAs. Additionally that statement is inaccurate. Google currently requires all apps (new or updates) to be targeting API 29. They will begin forcing API 30 on new apps starting August 2021 and on existing apps receiving updates starting November 2021. See their timeline here |
My bad, sorry you are right it's only in August. Safe then. Thank you for your answer |
Could you please explain how you implement this? (with code) |
I think |
Any chance of merging this any time soon? Android 11 will be required for all apps starting in November. |
c0a4243
to
a0485d6
Compare
We also launch CROP intent here https://github.com/apache/cordova-plugin-camera/blob/master/src/android/CameraLauncher.java#L417, so should probably be added too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested this on android 11 target sdk 30
Taken from Issue apache#684 on the main Camera Plugin project: apache#684
Platforms affected
android
Motivation and Context
Fixes issues that were introduced with the new Android 11 (SDK 30) package visibility restrictions.
Description
Explicitly sets the package visibility for:
closes #673
Which is used by the camera and gallery.
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)