Bugfix issue 665

[PieterVanPoyer]

Platforms affected

Android

Motivation and Context

Fixes #665
Fixes #696

Description

In the processResultFromCamera method, the imageFilePath is used.
https://github.com/apache/cordova-plugin-camera/blob/master/src/android/CameraLauncher.java#L475
It was not restored when the activity was destroyed.

cordova-plugin-camera/src/android/CameraLauncher.java

Line 1356 in b43c78b

public void onRestoreStateForActivityResult(Bundle state, CallbackContext callbackContext) {

This resulted in a NullPointerException because the resulting sourcePath was null.

cordova-plugin-camera/src/android/CameraLauncher.java

Line 473 in b43c78b

String sourcePath = (this.allowEdit && this.croppedUri != null) ?

So I've added the imageFilePath to the state Bundle in the saveInstance and the restoreInstance methods.

You can install and test the plugin (on Android) with next command.

npx cordova plugin remove cordova-plugin-camera
npx cordova plugin add https://github.com/PieterVanPoyer/cordova-plugin-camera/#bugfix/issue-665-save-instance-restore-bug

You could test it with next reproduction repo:
https://github.com/PieterVanPoyer/cordova-camera-plugin-testing-app

Testing

Tested it on an Android 10 emulator.
I enabled the developers mode on the emulator and made the activity destroy everytime the camera is shown.
So I forced the resume flow on Android

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[PieterVanPoyer]

@breautek @jcesarmobile @erisu Is anybody able to review this PR? Kind regards.

[breautek]

lgtm

[PieterVanPoyer]

@breautek @erisu maybe it's time to merge this one. And start a release. Some users report that this PR fixes the linked issues.

Kind regards
Pieter

[PieterVanPoyer]

@timbru31 thanks for the review. I did commit your suggestion.

[PieterVanPoyer]

@timbru31 or @breautek can anyone merge this one to the master. Most users report that this PR fixes the linked issues.

[breautek]

Generally I like to have 2 green checks, but I'll merge sometime Monday assuming there are no objections. Sooner if I get another green check from a PMC member.

[breautek]

Tests are green, and haven't had any objections so merging!

Thank you for your contribution @PieterVanPoyer

[FlossyWeb]

Hi there,
Are you planning to update the npm package anytime soon ?
It would be nice...
Thank you guys

[codeconsole]

Any chance for a merge or at least a comment on #712 ?

[satheeshkumartitan]

I've also updated the latest plugin 5.0.2, but the same problems occur on Android 10 (device - redmi note 7pro). The plugin 5.0.2. Forcefully close the application once we capture a photo. This happens on some specific devices. Please update the new version I'm waiting for the new version
Node -v ----14.16.0
ionic -v ---- 6.13.1
cordova -v----10.0.0
ionic cordova platform add [email protected]
npm i @ionic-native/[email protected]
tested and both same crash.

I'm waiting for your response, thanks

[jay34fr]

Hi all,
Same issue here.
I updated to 5.0.2 but the app is still restarting after taking and validating a photo.

Cordova 9.0.0
Cordova Android 9.0.0