Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removed misleading text #194

Merged
merged 1 commit into from
Mar 30, 2020
Merged

docs: Removed misleading text #194

merged 1 commit into from
Mar 30, 2020

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Mar 30, 2020

"This API is based on the W3C Geolocation API Specification, and only executes on devices that don't already provide an implementation."

is misleading because it sounds like you do not need the plugin if the browser has geolocation support,
however, the plugin still handles permissions regardless if it provides
a geolocation implementation or not.

Closes #186

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

"This API is based on the W3C Geolocation API Specification, and only executes on devices that don't already provide an implementation."

is misleading because it sounds like you do not need the plugin if the browser has geolocation support,
however, the plugin still handles permissions regardless if it provides
a geolocation implementation or not.
@breautek breautek requested a review from timbru31 March 30, 2020 01:32
@timbru31 timbru31 merged commit 70f3d6e into apache:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation seems misleading about whether or not the plugin is necessary
2 participants