-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With the new ios inappbrowser change for wkwebview support, the main webview content is disabled #334
Comments
I created a simple UIWebView cordova app with just inappbrowser plugin, and it can repeat the same issue. The project (basictest.zip) is also shared at the folder of The project only has a simple openInappbrowser button, once it is opened, then clicking done button to close the inappbrowser. After the inappbrowser is closed. Clicking on the openInappbrowser button again will do nothing. This indicates the issue is in the new inappbrowser plugin's implementation. Jonathan |
The bug was caused by PR #284 (prior to this, the window level was set to This issue is also covered by #314. |
Just found out the issue is caused by the below code in CDVUIInAppbrowser.m If commenting out the above code, then the function will works as expected. I will submit a pull request to remove the code to set the window level for inappbrowser UIWindow. Jonathan |
Thanks Dpa99c. Jonathan |
Just upgrade our product ios Fiori client app with the updated inappbrowser plugin for master with the wkwebview support.
However, somehow after loading the web content in the main webView (UIWebView or WKWebView), the UI element in the main webview is disabled. Clicking on the button or other UI element does not have any response.
The same app with inappbrowser version 2.0 works as expected.
To repeat the issue, the three ios projects are shared at the below folder:
https://sap-my.sharepoint.com/:f:/p/jonathan_li/EmulfDR6x9RBuQdj5u1-NrwBYchculWO6RAfoC_NTM8XLw?e=YzzUkh
2.0WithUIWebView.zip
Fiori client build with inappbrowser plugin version 2.0.x. The main webview uses UIWebView.
masterWithUIWebview.zip
Fiori client build with inappbrowser plugin from master. The main webview uses UIWebView.
masterWithWKWebView.zip
Fiori client built with inappbrowser plugin from master. The main webview uses WKWebView.
Steps to repeat the issue:
When the project is built with inappbrowser 2.0 and UIWebView (2.0WithUIWebView.zip), click the "See it in action" button will go to the next page. In addition, double tab on the screen will show the toolbar items.
But after upgrading the project to latest inappbrowser plugin (masterWithUIWebview.zip), the main UIWebview does not response to the button click, or double tab. I also built a project with WKWebView as main UIwebView (masterWithWKWebView.zip), and got the same result.
Please look into this issue and see what causes this behavior change, particularly for the case when UIWebView is used as main webView.
Thanks
Jonathan
The text was updated successfully, but these errors were encountered: