-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme.md by adding missing info #239
Conversation
Because the two changes included in this PR is not really related I feel like these changes should be two different PRs (or at the very least, 2 different commits). One for the iOS note, another for xxxhdpi screen size. |
You are true, but these are information need to update readme file to new info. I don’t think it is matter to use into 2 PR because it is update the documents to the new details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update text as standard text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@breautek Could you please take a look now, thanks |
I update it as standard as you mentioned, please check |
The text is now as standard method, please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change 😄
We lost our newline along the way,
Thanks for info, updated ! , please review it. |
Thanks for your contribution, I think this is good enough merge! |
Platforms affected
iOS & Android
Description
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)