Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: replace jshint with eslint #277

Merged
merged 4 commits into from
Jun 26, 2020
Merged

breaking: replace jshint with eslint #277

merged 4 commits into from
Jun 26, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 26, 2020

Motivation, Context & Description

  • Replace jshint with Cordova's ESLint package
  • Remove any jshint references & config files
  • Run and applied auto corrections from ESLint

Note: This PR also contains #276 changes. PR #276 should be reviewed and merged first.

Testing

  • See CI Service's Results

@erisu erisu added this to the 6.0.0 milestone Jun 26, 2020
@erisu erisu requested review from timbru31 and NiklasMerz June 26, 2020 03:56
@erisu erisu force-pushed the breaking/improve-lint branch from a682313 to 0de2acd Compare June 26, 2020 10:00
@erisu erisu requested a review from timbru31 June 26, 2020 10:03
@erisu erisu merged commit 893ba08 into apache:master Jun 26, 2020
@erisu erisu deleted the breaking/improve-lint branch June 26, 2020 10:31
@erisu erisu mentioned this pull request Jun 26, 2020
Closed
2 tasks
@timbru31
Copy link
Member

Part of apache/cordova#142, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

@NiklasMerz NiklasMerz Awaiting requested review from NiklasMerz

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @timbru31