Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-9841 - Allow iOS statusbar to animate hide/show #37

Conversation

andreistanica
Copy link

I've modified the statusbar.js file to take 2 optional parameters on hide() and show(), animated and duration.
I've also changed the CDVStatusBar.m file to add read the parameters and correctly choose to animate or not the statusbar refresh.

If anyone has any questions regarding this feature let me know.

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Mac Link Link Link
Android Windows Link Link Link

@hirbod
Copy link

hirbod commented Aug 2, 2016

Just came here to see if there is any solution to fade the status bar - and there we go. I don't understand why this isnt merged. Could you guys please add this into the plugin?

@ajarbol
Copy link

ajarbol commented Feb 8, 2017

+1

bohemel added a commit to Understandit/cordova-plugin-statusbar that referenced this pull request Jun 9, 2017
@timbru31
Copy link
Member

Any news on this, besides the merge conflict? Would love to see this merged.

@InternetExplorer8
Copy link

Any chance to get this merged? Any way we can help out?

@janpio
Copy link
Member

janpio commented Jul 18, 2018

Yes, someone could create a new PR where the merged conflict is resolved please, then someone could take a look @InternetExplorer8 @timbru31

In general:
Is this an iOS only feature or is this also possible on other platforms?

@timbru31
Copy link
Member

@janpio I've re-done the PR! 🎉
AFAIK in Android you can't animate the status bar. (just did a quick Google search)

@timbru31
Copy link
Member

timbru31 commented May 7, 2019

Closing since I've re-done the PR in #123. I've kept your original commit @andreistanica - thank you very much for your contribution!

@timbru31 timbru31 closed this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants