-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-9841 - Allow iOS statusbar to animate hide/show #37
CB-9841 - Allow iOS statusbar to animate hide/show #37
Conversation
Cordova CI Build has completed successfully. Commit - Link
|
Just came here to see if there is any solution to fade the status bar - and there we go. I don't understand why this isnt merged. Could you guys please add this into the plugin? |
+1 |
Any news on this, besides the merge conflict? Would love to see this merged. |
Any chance to get this merged? Any way we can help out? |
Yes, someone could create a new PR where the merged conflict is resolved please, then someone could take a look @InternetExplorer8 @timbru31 In general: |
@janpio I've re-done the PR! 🎉 |
Closing since I've re-done the PR in #123. I've kept your original commit @andreistanica - thank you very much for your contribution! |
I've modified the statusbar.js file to take 2 optional parameters on hide() and show(), animated and duration.
I've also changed the CDVStatusBar.m file to add read the parameters and correctly choose to animate or not the statusbar refresh.
If anyone has any questions regarding this feature let me know.